Skip to content

[O2B-1240] Display only physical productions by default and adds filtering for 'test' and 'debug' productions display#1940

Merged
xsalonx merged 29 commits into
mainfrom
xsalonx/O2B-1240/display-only-physical-productions
Jul 30, 2025
Merged

[O2B-1240] Display only physical productions by default and adds filtering for 'test' and 'debug' productions display#1940
xsalonx merged 29 commits into
mainfrom
xsalonx/O2B-1240/display-only-physical-productions

Conversation

@xsalonx

@xsalonx xsalonx commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • By default test and debug productions are excluded from data passes views. They can be included using filtering panel.

Notable changes for developers:

  • Refactor Data passes overview models

Changes made to the database:

  • NA

@codecov

codecov Bot commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.08696% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.77%. Comparing base (3444017) to head (bbb4f67).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/utilities/expandNestedKey.js 0.00% 15 Missing ⚠️
...public/views/DataPasses/DataPassesOverviewModel.js 0.00% 15 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 6 Missing ⚠️
...ic/domain/enums/NonPhysicsProductionsNamesWords.js 0.00% 2 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 2 Missing ⚠️
...iodOverview/DataPassesPerLhcPeriodOverviewModel.js 0.00% 2 Missing ⚠️
lib/server/controllers/dataPasses.controller.js 77.77% 2 Missing ⚠️
...ts/Filters/common/filters/TextTokensFilterModel.js 0.00% 1 Missing ⚠️
...c/components/Filters/common/filtersPanelPopover.js 0.00% 1 Missing ⚠️
...erview/DataPassesPerSimulationPassOverviewModel.js 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
+ Coverage   45.54%   45.77%   +0.22%     
==========================================
  Files        1010     1014       +4     
  Lines       16680    16699      +19     
  Branches     2997     3006       +9     
==========================================
+ Hits         7597     7644      +47     
+ Misses       9083     9055      -28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx changed the title Xsalonx/o2 b 1240/display only physical productions [O2B-1240] Display only physical productions Jul 24, 2025
@xsalonx xsalonx self-assigned this Jul 24, 2025
@xsalonx xsalonx marked this pull request as ready for review July 24, 2025 16:13
@xsalonx xsalonx requested a review from graduta as a code owner July 24, 2025 16:13
graduta
graduta requested changes Jul 28, 2025
View reviewed changes
Comment thread test/api/dataPasses.test.js Outdated
Comment thread lib/public/components/Filters/common/FilteringModel.js Outdated
Comment thread lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js Outdated
Comment thread lib/public/views/DataPasses/DataPassesOverviewModel.js
Comment thread lib/public/components/Filters/common/FilteringModel.js
@xsalonx xsalonx requested a review from graduta July 29, 2025 07:28
graduta
graduta requested changes Jul 30, 2025
View reviewed changes

@graduta graduta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the addition of [include][byName] it adds complexity without any benefit. It is not the same as the numerical values where we have to specify operator and limit.
In this case, it is a simple inclusion of strings

Comment thread lib/public/components/Filters/common/FilteringModel.js Outdated
Comment thread lib/public/components/Filters/common/FilteringModel.js Outdated
Comment thread lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js
Comment thread lib/public/views/DataPasses/DataPassesOverviewModel.js Outdated
@xsalonx xsalonx requested a review from graduta July 30, 2025 10:11
@graduta graduta changed the title [O2B-1240] Display only physical productions [O2B-1240] Display only physical productions by default and adds filtering for 'test' and 'debug' productions display Jul 30, 2025
@xsalonx xsalonx merged commit 64a1438 into main Jul 30, 2025
23 of 24 checks passed
@xsalonx xsalonx deleted the xsalonx/O2B-1240/display-only-physical-productions branch July 30, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

Assignees

@xsalonx xsalonx

Labels

backend frontend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xsalonx @graduta